Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow body for delete request #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

f3c0
Copy link

@f3c0 f3c0 commented Oct 29, 2019

Hey
I'd like to be able to add body for the delete request too
thanks

@alexandre-kivra
Copy link
Contributor

Hi. We will have to think about this change. Even though according to the RFC7231 sending a body on a DELETE request is no longer forbidden some server may reject it. Since our current implementation in case of passing an empty list will actually send <<"[]">> this may break some implementations if the server rejects DELETE with body.

@f3c0
Copy link
Author

f3c0 commented Oct 30, 2019

yes, I was thinking on that too
It should be able to send empty body, for now even if the body is just a <<>>, it sends "\"\"" which is still not empty (in case the type is json)
One option is to allow raw/text type, but the problem if as I saw, the request type and the response type right now the same parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants