refactor: Fix version, update elvis config and variable renaming #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kivra-pauoli
approved these changes
Aug 29, 2024
|
I think it's failing because of https://github.com/kivra/id_token/blob/master/Makefile#L36 (head 😖); your the change is sane, though. Would it be Ok for you to use the |
|
Feel to free to help me out here @kivra-pauoli :) |
A proper fix would probably be to not avoid it, but 1. that'd change code, which is not our priority here, 2. that might not be easy to achieve when macros are involved
kivra-pauoli
force-pushed
the
jz-fix-incorrect-version
branch
from
e2028f0
to
fbc814e
Compare
Instead of an actual fix we work around it by allowing it; on the other hand I'm not sure why it exists in the code but it's not our priority to check that now
|
@zigge-zagge, we're back in business. Feel free to merge; you have my blessing already. |
zigge-zagge
commented
Aug 29, 2024
There was a problem hiding this comment.
All this means the ruleset rules are applied as default. There's a new ruleset (strict) that we can try in the future (that includes more stricter default rules).
|
Nice work @kivra-pauoli! |
zigge-zagge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't create a release but I think that's better than to let a change like this propagate :)