[BUGFIX] Change metadata to keep arrays instead of strings #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-meyer
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Apart from the fix for two-level metadata fields by @chrizzor this looks fine!
|
I am merging this to at least have a fix for "normal" metadata in 5.x branch. But I'll keep #1308 open, because it still won't work for two-level metadata (see my comment above). Thank you very much for this very important fix, @beatrycze-volk! |
sebastian-meyer
approved these changes
Sep 20, 2024
This was referenced Sep 20, 2024
sebastian-meyer
added a commit
that referenced
this pull request
Sep 20, 2024
Co-authored-by: Sebastian Meyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change restores correct displaying of metadata.
Closes #1317