Updated Readme and Manifest with GR 3.10 compatability #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noc0lour
reviewed
Apr 10, 2024
| - UHD = 3.15 | ||
| - QT 5.10.1 | ||
| - Qwt = 6.1.0 | ||
| - python-matplotlib | ||
| repo: https://github.com/kit-cel/gr-radar | ||
| website: https://grradar.wordpress.com | ||
| gr_supported_version: v3.7, v3.8 | ||
| gr_supported_version: v3.7, v3.8, v3.10 |
There was a problem hiding this comment.
Are all versions supported at the same time? I'd think that 3.7 & 3.8 won't work after the update to 3.10?
There was a problem hiding this comment.
Well... Only 3.10 will work on this branch, but the repo has branches for maint-3.7 and maint-3.8. Currently CGRAN only displays the info from the default branch. Including all the available supported versions in the manifest is the current "standard practice". Improving/changing this is a CGRAN level discussion. The Readme, more relevant to people viewing the repo and source code only mentions 3.10 support.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't checked or updated the other dependencies, but at least this should help clarify things on CGRAN and people reading the repo. Can this also be branched as
maint-3.10please?