Ack empty segments

kim-company · Aug 4, 2023 · aace0f0 · aace0f0
1 parent 873ab06
commit aace0f0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/membrane/hls/sink.ex b/lib/membrane/hls/sink.ex
@@ -247,7 +247,8 @@ defmodule Membrane.HLS.Sink do
     {notifications, builder} =
       case response do
         :ok ->
-          {[notify_parent: {id, :write, :ok, metadata}], Builder.ack(state.builder, segment.ref)}
+          {[notify_parent: {id, :write, :ok, metadata}],
+           Builder.ack(state.builder, segment.ref, Enum.empty?(buffers))}
 
         {:error, reason} ->
           {[notify_parent: {id, :write, {:error, reason}, metadata}],

diff --git a/mix.lock b/mix.lock
@@ -4,7 +4,7 @@
   "coerce": {:hex, :coerce, "1.0.1", "211c27386315dc2894ac11bc1f413a0e38505d808153367bd5c6e75a4003d096", [:mix], [], "hexpm", "b44a691700f7a1a15b4b7e2ff1fa30bebd669929ac8aa43cffe9e2f8bf051cf1"},
   "hackney": {:hex, :hackney, "1.18.1", "f48bf88f521f2a229fc7bae88cf4f85adc9cd9bcf23b5dc8eb6a1788c662c4f6", [:rebar3], [{:certifi, "~>2.9.0", [hex: :certifi, repo: "hexpm", optional: false]}, {:idna, "~>6.1.0", [hex: :idna, repo: "hexpm", optional: false]}, {:metrics, "~>1.0.0", [hex: :metrics, repo: "hexpm", optional: false]}, {:mimerl, "~>1.1", [hex: :mimerl, repo: "hexpm", optional: false]}, {:parse_trans, "3.3.1", [hex: :parse_trans, repo: "hexpm", optional: false]}, {:ssl_verify_fun, "~>1.1.0", [hex: :ssl_verify_fun, repo: "hexpm", optional: false]}, {:unicode_util_compat, "~>0.7.0", [hex: :unicode_util_compat, repo: "hexpm", optional: false]}], "hexpm", "a4ecdaff44297e9b5894ae499e9a070ea1888c84afdd1fd9b7b2bc384950128e"},
   "idna": {:hex, :idna, "6.1.1", "8a63070e9f7d0c62eb9d9fcb360a7de382448200fbbd1b106cc96d3d8099df8d", [:rebar3], [{:unicode_util_compat, "~>0.7.0", [hex: :unicode_util_compat, repo: "hexpm", optional: false]}], "hexpm", "92376eb7894412ed19ac475e4a86f7b413c1b9fbb5bd16dccd57934157944cea"},
-  "kim_hls": {:git, "https://github.com/kim-company/kim_hls.git", "7ac2d486f1b9dfb74e5a369985f7801849c1e170", []},
+  "kim_hls": {:git, "https://github.com/kim-company/kim_hls.git", "16b71bf8f0a68cefb6b15961ae1e1376872cf986", []},
   "kim_q": {:git, "https://github.com/kim-company/kim_q.git", "4a4924efead4230e488375fe9e2aa817931cd05a", []},
   "membrane_core": {:hex, :membrane_core, "0.12.6", "286c00d814d2a85fcd34926cdfd38ad45903eec43fe93ba47ce313358571eccd", [:mix], [{:bunch, "~> 1.6", [hex: :bunch, repo: "hexpm", optional: false]}, {:qex, "~> 0.3", [hex: :qex, repo: "hexpm", optional: false]}, {:ratio, "~> 2.0", [hex: :ratio, repo: "hexpm", optional: false]}, {:telemetry, "~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "9169c1f87e76a9cee21dbcdda36d75a131e290a4be9c8919fe1ff413c7be641e"},
   "membrane_file_plugin": {:hex, :membrane_file_plugin, "0.14.0", "87f19f5f5afbfbaf2219b8f1d8496534cb9ad01fca74687910bf3f7aa866e244", [:mix], [{:membrane_core, "~> 0.12.0", [hex: :membrane_core, repo: "hexpm", optional: false]}], "hexpm", "28956f8d5d87735d499c57f1c24f62aeab71e0211863759e7e695ead966eb433"},