Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purge maistra related stuff #723

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli commented Nov 3, 2023

part of kiali/kiali#6816

see also: kiali/kiali#6819

to test, see test procedures here

@jmazzitelli jmazzitelli marked this pull request as ready for review November 15, 2023 02:21
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. Do we have any maistra-specific content on kiali.io (other than the compatibility chart)?

@jmazzitelli
Copy link
Contributor Author

This looks fine. Do we have any maistra-specific content on kiali.io (other than the compatibility chart)?

Good question. I will check.

@jmazzitelli
Copy link
Contributor Author

This looks fine. Do we have any maistra-specific content on kiali.io (other than the compatibility chart)?

Only other place is https://kiali.io/docs/configuration/namespace-management/#accessible-namespaces

Maistra supports multi-tenancy and the accessible_namespaces extends that feature to Kiali. However, explicit naming of accessible namespaces can benefit non-Maistra installations as well - with it Kiali does not need cluster roles and the Kiali Operator does not need permissions to create cluster roles.

@jshaughn
Copy link
Contributor

Only other place is https://kiali.io/docs/configuration/namespace-management/#accessible-namespaces

I think we can remove this blurb as well, but I can do it as part of the next release notes PR, which also has to update a couple of other things. This will remain in the 1.73 version of the docs (and all other maistra release versions of the docs).

@jmazzitelli
Copy link
Contributor Author

Only other place is https://kiali.io/docs/configuration/namespace-management/#accessible-namespaces

I think we can remove this blurb as well, but I can do it as part of the next release notes PR, which also has to update a couple of other things. This will remain in the 1.73 version of the docs (and all other maistra release versions of the docs).

I created a PR for this already, let it be attached to this issue:

kiali/kiali.io#719

@jmazzitelli jmazzitelli merged commit efd21f8 into kiali:master Nov 16, 2023
1 check passed
@jmazzitelli jmazzitelli deleted the 6816-remove-maistra branch November 16, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants