Update CRD schema for auto_enable in graph options #665
Conversation
There was a problem hiding this comment.
Since this is just a standard, normal setting, let's make sure to also define the default in the defaults file: https://github.com/kiali/kiali-operator/blob/master/roles/default/kiali-deploy/defaults/main.yml
crd-docs/crd/kiali.io_kialis.yaml
Outdated
| @@ -1057,6 +1057,9 @@ spec: | |||
| expression: | |||
| description: "The find expression." | |||
| type: string | |||
| auto_enable: | |||
| description: "Enabled option by default" | |||
| type: boolean | |||
There was a problem hiding this comment.
alphabetize the list, please :)
There was a problem hiding this comment.
Updated. Thanks for the review, @jmazzitelli !
There was a problem hiding this comment.
I'm ok with this. @jshaughn originally wrote this stuff, have him take a look just so he at least knows about this.
Co-authored-by: John Mazzitelli <[email protected]>
Co-authored-by: John Mazzitelli <[email protected]>
|
I've made the changes for renaming. |
I'm OK leaving them. I like being explicit in that defaults yaml file. When I first started this, I made sure I put everything in there for consistency and to be explicit, to ensure the ConfigMap was the source of truth for the server and not that config.go hardcoded defaults. So to remain consistent with everything else, I would leave all of that in there. |
Ref. kiali/kiali#6316