Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support namespaces with just numerals in their names #284

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

jmazzitelli
Copy link
Contributor

part of: kiali/kiali#7773

To test:

server helm chart

  1. make build-helm-charts
  2. kubectl create ns 12345
  3. helm install --namespace 12345 kiali-server _output/charts/kiali-server*.tgz

It should install fine, with no errors from helm. The server won't start because its trying to pull an image that doesn't exist, but that is irrelevant for this issue. We just want to make sure helm does not fail.

You can uninstall with:

helm uninstall --namespace 12345 kiali-server

operator helm chart

  1. make build-helm-charts
  2. kubectl create ns 12345
  3. helm install --namespace 12345 --set cr.create=true kiali-operator _output/charts/kiali-operator*.tgz

It should install fine, with no errors from helm. The operator won't start because its trying to pull an image that doesn't exist, but that is irrelevant for this issue. We just want to make sure helm does not fail.

You can uninstall with deleting the CR first, then the operator:

kubectl delete kiali -n 12345 --all && helm uninstall -n 12345 kiali-operator

Copy link

@aljesusg aljesusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@aljesusg aljesusg merged commit ea378e1 into kiali:master Sep 26, 2024
1 check passed
@jmazzitelli jmazzitelli deleted the 7773-numeral-namespace-names branch September 26, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants