Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopscotch Hashing [Ready] #128

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

Conversation

AndreyFdrv
Copy link

No description provided.

@AndreyFdrv
Copy link
Author

Выполнили:
Федоров Андрей, 3304
Леончик Александр, 3304
Тан Голян, 3303
Алаеров Шохинджон, 3303

@AndreyFdrv
Copy link
Author

Основан на #106

@AndreyFdrv AndreyFdrv changed the title Hopscotch Hashing(на основе https://github.com/khizmax/libcds/pull/106) Hopscotch Hashing Dec 27, 2018
@AndreyFdrv AndreyFdrv changed the title Hopscotch Hashing Hopscotch Hashing [Ready] Dec 29, 2018
@AndreyFdrv AndreyFdrv changed the title Hopscotch Hashing [Ready] Hopscotch Hashing [Not ready] Dec 29, 2018
@DaKellyFella
Copy link

Underlying algorithm.

The underlying algorithm that you use in your implementation is the inferior, fixed-sized neighbourhood version. Someone else submitted the same algorithm a while back (you linked it at the top, #106 ) and it was equally bad. The superior algorithm can be found here in the appendix. Here is an example implementation by the original authors. This would be a much better basis for a Hopscotch Hashing submission.

Implementation.

Your implementation is again VERY similar to the one submitted previously and just as strange. Someone clearly stole this code without proper reference from here. I called out the original submission in #106 and I'm calling you out again. This is the second time someone has tried to pass of this code as their own, or at least without proper citation. It's getting quite annoying.

@AndreyFdrv AndreyFdrv changed the title Hopscotch Hashing [Not ready] Hopscotch Hashing [Ready] Jan 15, 2019
@eugenyk
Copy link
Contributor

eugenyk commented Jan 17, 2019

According to jenkins there is a problem with build

@AndreyFdrv
Copy link
Author

AndreyFdrv commented Jan 19, 2019

I checked build on Windows 10 and Linux Ubuntu 16.04 LTS and build was successfull in both cases.

@AndreyFdrv
Copy link
Author

I see that problem caused by renaming file from "map_insdel_string_feldman_hashset.cpp" to "map_insdel_string_feldman_hashmap.cpp" in test\stress\map\insdel_string folder

@AndreyFdrv
Copy link
Author

I thought that filename is wrong because this file is located in map folder but have "hashset" in the name. So I changed the name.

@AndreyFdrv
Copy link
Author

I will fix CMakeLists.txt

@AndreyFdrv
Copy link
Author

I fixed problem with build

@eugenyk
Copy link
Contributor

eugenyk commented Jan 27, 2019

According to the repository rules in README all pull requests should be prepared for "integration" branch, not "master"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants