Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

files compressed #256

Merged
merged 2 commits into from
Jul 7, 2024
Merged

files compressed #256

merged 2 commits into from
Jul 7, 2024

Conversation

Markio125
Copy link
Contributor

image files have been compressed

@Markio125 Markio125 self-assigned this Jul 7, 2024
Goose-Of-War
Goose-Of-War requested changes Jul 7, 2024
View reviewed changes
Copy link
Member

@Goose-Of-War Goose-Of-War left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all files should be less than 200kb in size (max permissible size 250kb, worst case scenario)

ItsAnkan
ItsAnkan requested changes Jul 7, 2024
View reviewed changes
Copy link
Member

@ItsAnkan ItsAnkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

202407-04, 05, 06, 07, 11, 13, 15
All are above 300kb

And as senpai said, you may as well compress it to be below 250kb

Goose-Of-War
Goose-Of-War approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@Goose-Of-War Goose-Of-War left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

@Goose-Of-War
Copy link
Member

please stop using this branch and make branches for each specific work ;-;

ItsAnkan
ItsAnkan approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@ItsAnkan ItsAnkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@ItsAnkan
Copy link
Member

ItsAnkan commented Jul 7, 2024

btw... did you change the hypes ?

@Markio125 Markio125 merged commit bf77d4f into dev Jul 7, 2024
4 checks passed
@Markio125 Markio125 deleted the Markio branch July 7, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goose-Of-War Goose-Of-War Goose-Of-War approved these changes

@ItsAnkan ItsAnkan ItsAnkan approved these changes

Assignees

@Markio125 Markio125

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Markio125 @Goose-Of-War @ItsAnkan