Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate discord hooks #216

Merged
merged 11 commits into from
Jul 15, 2023
Merged

Separate discord hooks #216

merged 11 commits into from
Jul 15, 2023

Conversation

SachdevJai
Copy link
Contributor

No description provided.

@SachdevJai SachdevJai linked an issue Jul 13, 2023 that may be closed by this pull request
Separate Discord Hooks #193
Closed
@SachdevJai SachdevJai added this to the Discord Hooks milestone Jul 13, 2023
@SachdevJai SachdevJai changed the title added discord webhook for submission form Separate discord hooks Jul 13, 2023
Goose-Of-War
Goose-Of-War requested changes Jul 13, 2023
View reviewed changes
Copy link
Member

@Goose-Of-War Goose-Of-War left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We should rename alertToDiscord to something like codeUpdateErrorHook, since all Discord Hooks technically alert to Discord.
  2. Discord hook in submission will be done once it's added to the database, using the submitted MongoDB object instead of the req.body data.
  3. As mentioned in Discord, the link should also be in the hook.

Goose-Of-War
Goose-Of-War requested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@Goose-Of-War Goose-Of-War left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need env.js and hook link changes too onegai

Goose-Of-War
Goose-Of-War approved these changes Jul 15, 2023
View reviewed changes
Copy link
Member

@Goose-Of-War Goose-Of-War left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SachdevJai next time, resolve the merge conflicts too

@Goose-Of-War Goose-Of-War merged commit d72989a into dev Jul 15, 2023
4 checks passed
@Goose-Of-War Goose-Of-War deleted the discord-hooks branch July 15, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goose-Of-War Goose-Of-War Goose-Of-War approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Discord Hooks
Development

Successfully merging this pull request may close these issues.

Separate Discord Hooks
2 participants
@SachdevJai @Goose-Of-War