Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form Uniformity #212

Merged
merged 14 commits into from
Jul 14, 2023
Merged

Form Uniformity #212

merged 14 commits into from
Jul 14, 2023

Conversation

ItsAnkan
Copy link
Member

@ItsAnkan ItsAnkan commented Jul 7, 2023 •
edited
Loading

What has been changed here -

  • Moved all form CSS to a separate SCSS file to be used when forms are involved
  • Set up a njk file containing all form elements in macro form so as to create a form with use
  • Created useful functions to extract data from forms
  • Migrated most of the forms to use this format
  • Add a Forms.md to have a detailed explanation about using forms
  • Edited README.md for form guide
  • Fixed Uniformity in forms #205
  • Cleanup stuff used for testing

@ItsAnkan
Copy link
Member Author

@Goose-Of-War this is unrelated to this PR, but the message container in the forms needs fixing, it doesn't behave as its supposed to for mobile displays. Will have to make an issue for that

Goose-Of-War
Goose-Of-War approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@Goose-Of-War Goose-Of-War left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green light

@ItsAnkan ItsAnkan merged commit f23a55e into dev Jul 14, 2023
4 checks passed
@Goose-Of-War Goose-Of-War deleted the form-uniformity branch July 15, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goose-Of-War Goose-Of-War Goose-Of-War approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uniformity in forms
2 participants
@ItsAnkan @Goose-Of-War