-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade design system #9253
base: main
Are you sure you want to change the base?
Upgrade design system #9253
Conversation
@jossmac - How do you test for a wide range of fields, do you run the sandbox with "all the things"? We used a Status select which made everything read only once past "draft". This showed a bunch of UX that could be improved - they may seem as less common use-cases, but I have noticed a lot of projects that use in this way (and have done myself a few times).
-- We could add a simple checkbox to make them all read only in the sandbox project - wdyt @dcousens? |
@kennedybaird I think adding a checkbox (or cookie, or) that can easily switch between different field modes will be incredibly helpful in debugging UX |
@dcousens - to clarify, you'd like this to expand the current |
|
@jossmac I am sure you have noticed my work in #9186 |
@@ -1,43 +1,9 @@ | |||
/** @jsxRuntime classic */ | |||
/** @jsx jsx */ | |||
|
|||
import 'intersection-observer' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add 'use client' here, this is harmless in non ssr but useful in SSR with upcoming changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gautamsi any reason not to do this in the upcoming changes rather than this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally on board with SSR friendly! This PR is pretty massive in scope, let's focus on app-router etc. after it's landed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to get this design uplift, would love to see this coming. wait is killing!!
96049f6
to
f4d16cc
Compare
aa587b9
to
2c0b220
Compare
2c0b220
to
3ed0edd
Compare
b7d26a3
to
1368261
Compare
bandaid until all "@keystone-ui" instances replaced with "@keystar/ui"
this might negatively affect keystar-ui components…
improve accessibility and responsiveness
avoid showing validation prematurely
still needs filters
Known issues:
Potential improvements:
|
(this is a draft)