-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ruby 3.0.x #32
Conversation
alachaum
commented
May 31, 2021
•
edited
Loading
edited
- Refactor positional/keyword arguments to support ruby 3.0.x
- Separate test environments for ruby 2.5/2.6 / 2.7 / 3.x
- Skip Rails-specific tests when Rails in not in context
34a9647
to
7a0be4b
Compare
7da068d
to
d8a789f
Compare
Oh great!!!! I was actually bumping my head with this one when upgrading an app to ruby 3... what else is needed? |
I'm still getting an error when setting up a queue on Ruby 3.0.3, right where we're checking if the queue exists or not: require 'cloudtasker/backend/google_cloud_task'
require 'cloudtasker/config'
Cloudtasker::Backend::GoogleCloudTask.setup_queue(name: "default") Throws:
This is the call that is throwing the error: cloudtasker/lib/cloudtasker/backend/google_cloud_task.rb Lines 32 to 37 in 22ee4fe
And this is the method being called on |
The specs are not catching this because of rspec/rspec-mocks#1425 (comment) |
Thanks for the testing @vovimayhem ! I was actually planning to do another round of testing over the next couple of days. Ideally I want to merge this PR this week and make a release candidate. |
@vovimayhem release candidate |
I tried to make the specs detect that, but had no luck - I guess that rspec has yet to get the hash vs keywords thing right... |