-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Rails v7.2 #843
base: master
Are you sure you want to change the base?
Conversation
module ActiveRecordWhereAssoc | ||
module ActiveRecordCompat | ||
if ActiveRecord.gem_version >= Gem::Version.new('7.2.0.alpha') | ||
def self.normalize_association_name(name) = name.to_sym |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
b38eb80
to
69a27f3
Compare
953d70a
to
91fb970
Compare
91fb970
to
aeab923
Compare
b497cd1
to
af37a86
Compare
I give up. I tried various workarounds for rails/rails#51853, but I think this is a bug that needs to be fixed upstream. |
af37a86
to
6f7ef50
Compare
@ezekg Are you willing to try and bisect with your repro script to help identify the cause of the change? |
@zzak Sure. I posted the bisect results in rails/rails#51853 (comment). |
6ac3a00
to
3f9713f
Compare
3f9713f
to
cd38c21
Compare
I think failing tests are related to the export/import tests missing: before { Sidekiq::Testing.inline! }
after { Sidekiq::Testing.fake! } |
cd38c21
to
82431af
Compare
c317123
to
a1b2fea
Compare
a1b2fea
to
322ca46
Compare
WIP. Using the current release candidate.
Bullet doesn't support Rails v7.2 yet.