Feat/grpc #23
Open
Feat/grpc #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notes:
* grpcjs doesnt like ByteBuffer, it has been replaced with the nodejs
native Buffer
* grpcjs doesnt like calls without an argument, add {} instead
see src/grpc/subscribe.ts:24
* grpcjs converts uint64 in a map key (map<uint64, ...>) to some hash,
this is fixed with protobuf_long.patch which is automatically applied
after running `npm install`
this pr would fix the bug upstream protobufjs/protobuf.js#1669
I took the PR on the jscryptor github that removed the mcrypt dependecy and published it
I used `npm install depcheck -g` and then `depcheck` to find which dependecies were not being used in the project and then removed them from the package.json
kevkevinpal
force-pushed
the
master
branch
4 times, most recently
from
ad7b22d
to
c1d3f24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing to see if automated tests will pass