Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable-rc: fix BOOT TESTS section #554

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

JenySadadia
Copy link
Collaborator

Fix the below error while displaying boot failures when related build architecture information not found:

File "/workspace/kcidb/templates/stable_rc_test.j2", line 22, in template
    {% for architecture, tests in boot_tests|groupby("build.architecture") %}
  File "/layers/google.python.pip/pip/lib/python3.9/site-packages/jinja2/async_utils.py", line 45, in wrapper
    return normal_func(*args, **kwargs)
  File "/layers/google.python.pip/pip/lib/python3.9/site-packages/jinja2/filters.py", line 1261, in sync_do_groupby
    for key, values in groupby(sorted(value, key=expr), expr)
TypeError: '<' not supported between instances of 'str' and 'NoneType

Fix the below error while displaying boot failures
when related build architecture information not found:
```
File "/workspace/kcidb/templates/stable_rc_test.j2", line 22, in template
    {% for architecture, tests in boot_tests|groupby("build.architecture") %}
  File "/layers/google.python.pip/pip/lib/python3.9/site-packages/jinja2/async_utils.py", line 45, in wrapper
    return normal_func(*args, **kwargs)
  File "/layers/google.python.pip/pip/lib/python3.9/site-packages/jinja2/filters.py", line 1261, in sync_do_groupby
    for key, values in groupby(sorted(value, key=expr), expr)
TypeError: '<' not supported between instances of 'str' and 'NoneType
```

Signed-off-by: Jeny Sadadia <[email protected]>
Copy link
Collaborator

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spbnick spbnick merged commit 7c53b8b into kernelci:main Aug 8, 2024
5 of 6 checks passed
@JenySadadia JenySadadia deleted the fix-none-build-arch-error branch August 8, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants