Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump exception_page dependency #669

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Bump exception_page dependency #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad3f064
Bump `exception_page` to v0.4.0
Sija Dec 27, 2023
774de63
Fix issues found by ameba
Sija Dec 27, 2023
9eec7da
Fix deprecation
Sija Dec 27, 2023
7559f77
Update shard.yml
Sija Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dependencies:
version: ~> 0.4.0
exception_page:
github: crystal-loot/exception_page
version: ~> 0.3.0
version: ~> 0.4.1

development_dependencies:
ameba:
Expand Down
2 changes: 1 addition & 1 deletion spec/websocket_handler_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ describe "Kemal::WebSocketHandler" do

it "fetches named url parameters" do
handler = Kemal::WebSocketHandler::INSTANCE
ws "/:id" { |_, c| c.ws_route_lookup.params["id"] }
ws "/:id" { |_, context| context.ws_route_lookup.params["id"] }
headers = HTTP::Headers{
"Upgrade" => "websocket",
"Connection" => "Upgrade",
Expand Down
4 changes: 2 additions & 2 deletions src/kemal/config.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ module Kemal
end

private def setup_filter_handlers
FILTER_HANDLERS.each do |h|
HANDLERS.insert(@handler_position, h)
FILTER_HANDLERS.each do |handler|
HANDLERS.insert(@handler_position, handler)
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion src/kemal/ext/context.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class HTTP::Server
STORE_MAPPINGS = [Nil, String, Int32, Int64, Float64, Bool]

macro finished
alias StoreTypes = Union({{ *STORE_MAPPINGS }})
alias StoreTypes = Union({{ STORE_MAPPINGS.splat }})
@store = {} of String => StoreTypes
end

Expand Down
Loading