This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Deposit Submitter: Add tool for opening and funding deposits #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was getting in the way of imports resolving in VSCode.
Even though it's used later, having it up top makes it clear what usage will be when you open the file.
The fee estimator on BitcoinHelpers is about to get more correct, so change the usage of getMinimumRedemptionFee to be more explicit.
Also expose the minimum relay fee in ElectrumClient, though it's not exposed in BitcoinHelpers for the time being.
No idea why this defaults to off. For now we enable it globally instead of targeting contracts one-by-one. This seems more advisable, but could interfere with other folks' usage of the web3 object that is passed. Room for adjustment if that ends up being the case.
Currently with a hardcoded Ethereum account and Bitcoin wallet, opens a deposit every 2 minutes and funds it. Requests an up-front Bitcoin funding.
Shadowfiend
commented
Jul 21, 2020
| This flag repeatedly creates tBTC deposits and funds them. Rather | ||
| than waiting for each deposit's funding transaction to fully | ||
| confirm, a new deposit opened once the previous deposit's signing | ||
| group becomes available. |
There was a problem hiding this comment.
Worth flagging, current code doesn't pay attention to a -c flag, and though it reads the two file parameters, it ignores them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant for testing.