This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Register onError handler with Deposit autoSubmit function #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We let onError handling function to be provided with autoSubmit function so it's not necessary to call a separate function to register it. The argument is optional.
Shadowfiend
reviewed
Mar 23, 2021
|
|
||
| if (onError) { | ||
| this.eventEmitter.on("error", onError) | ||
| } |
There was a problem hiding this comment.
This isn't what I'd call the expected behavior, fwiw, because this keeps the error handler registered. Passing it to the function implies a single-shot usage. You could use .one here, but if there's no error invoked later on then that could lead to an unexpected call with a future error event.
I would just invoke this in the same place we trigger the event below, if it's defined.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up from https://github.com/keep-network/tbtc.js/pull/118/files#r578527898.
We let
onErrorhandling function be provided withautoSubmitfunction so it's not necessary to call a separate function to register it. The argument is optional.