Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom robots.txt in favor of RTD default #4055

Merged

Conversation

DimedS
Copy link
Contributor

@DimedS DimedS commented Aug 2, 2024

Description

This PR removes the custom robots.txt. The file automatically generated by Read the Docs (RTD) will be used during the build.

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Dmitry Sorokin <[email protected]>
@DimedS DimedS linked an issue Aug 2, 2024 that may be closed by this pull request
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be difficult to test this, but I'd just say let's go for it.

docs/source/conf.py Outdated Show resolved Hide resolved
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Dmitry Sorokin <[email protected]>
@astrojuanlu astrojuanlu mentioned this pull request Aug 21, 2024
7 tasks
@noklam
Copy link
Contributor

noklam commented Aug 21, 2024

Is this ready?

@DimedS
Copy link
Contributor Author

DimedS commented Aug 21, 2024

Is this ready?

This PR is ready, but the entire SEO optimisation isn't complete yet. If you're asking whether we should merge it before the release, I believe it's better to finish all the optimisations together. What do you think, @astrojuanlu?

@astrojuanlu
Copy link
Member

If I understand correctly, removing robots.txt will only increase the amount of URLs we're indexing, right? So maybe we can go ahead and try the sitemap separately? #3741 (comment)

@noklam noklam marked this pull request as ready for review August 21, 2024 16:07
@noklam noklam requested a review from yetudada as a code owner August 21, 2024 16:07
@noklam noklam self-requested a review August 21, 2024 16:07
@DimedS DimedS merged commit 0f93ee6 into main Aug 21, 2024
10 checks passed
@DimedS DimedS deleted the 3741-improve-seo-and-maintenance-of-documentation-versions branch August 21, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve SEO and maintenance of documentation versions
3 participants