Check if starter is used before printing tools message

[AhdraMeraliQB]

Description

As pointed out by @DimedS: xref

We don't allow users to select tools when using starters, so the message "you have selected no project tools" should not be displayed if a starter is used. This check was previously implicit, relying on the different values of tools to differentiate (previously '[]' and ['None']). These have since been unified, and as such, an explicit condition is required to ensure the message isn't printed when a starter is used.

Development notes

There are several alternatives for implementing this:

1. Move up the tool and example selection messages from L865 to L301, to access starter_alias <- current approach
2. Pass starter_alias through to _create_project as an argument
3. Pass starter_alias through as part of the extra_config to be accessed in _create_project <- original approach
4. Overhaul and refactor starters.py

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

• Read the contributing guidelines
• Signed off each commit with a Developer Certificate of Origin (DCO)
• Opened this PR as a 'Draft Pull Request' if it is work-in-progress
• Updated the documentation to reflect the code changes
• Added a description of this change in the RELEASE.md file
• Added tests to cover my changes
• Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

[merelcht]

The new function has become quite long. Maybe we can refactor this a bit. For example, extract lines 250-261

kedro/kedro/framework/cli/starters.py

Lines 250 to 261 in 30ce26c

	if checkout and not starter_alias:
	raise KedroCliError("Cannot use the --checkout flag without a --starter value.")
	if directory and not starter_alias:
	raise KedroCliError(
	"Cannot use the --directory flag without a --starter value."
	)
	if (selected_tools or example_pipeline) and starter_alias:
	raise KedroCliError(
	"Cannot use the --starter flag with the --example and/or --tools flag."
	)

into a separate function that validates the chosen arguments.

[merelcht]

The approach looks good to me 👍 I left some comments to tidy the code some more.

[merelcht]

Some minor comments from my side, but in general this is looking good!

[merelcht]

Why create a dict and not just directly pass the arguments to _validate_flag_inputs?

[DimedS]

I think it's in general a good idea - to put all CLI inputs to one dictionary, because currently there are a lot of them, but it should be done not only for one _validate_flag_inputs() function, but to the whole subsequent code. Better to do it little bit later - it will be a huge change, otherwise I cannot merge my current PR #3499 )

[AhdraMeraliQB]

I agree, the initial reason was due to how many inputs there are, and for future implementation/refactor as there is no guarantee that we won't need to pass these through later. I couldn't find any strong support for either convention, however, so I am mostly ambivalent. Though whatever we do choose, we should be sure to implement consistently.

[DimedS]

Thank you, @AhdraMeraliQB , awesome job! 👍

[merelcht]

LGTM 👍