[DRAFT] Fix/favicon and active tab #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 24, 2024 15:16
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
|
I created the Nothing to do here, with the SEO problems we have kedro-org/kedro#3741 better to not add another website to the mix. |
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Huongg
changed the title
Huongg
changed the title
added 14 commits
June 25, 2024 10:06
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
astrojuanlu
reviewed
Jun 25, 2024
| @@ -19,8 +19,14 @@ | |||
| extensions = [ | |||
| "myst_parser", | |||
| "sphinx_copybutton", | |||
| 'sphinx_favicon', | |||
There was a problem hiding this comment.
I think this is correct! And the only thing missing is adding "sphinx-favicon" to pyproject.toml as was done in https://github.com/kedro-org/kedro/pull/3547/files
There was a problem hiding this comment.
ah great, thanks for the suggestion, let me try that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://kedro-sphinx-theme--6.org.readthedocs.build/en/6/