Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ny lokal config for logback for å ha mer menneskelesbare logger #20

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Ny lokal config for logback for å ha mer menneskelesbare logger #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ece08f
set up local logging for human readable logs
anderssonw Jul 22, 2024
47cadbe
set logback default local and set jvm option in dockerfile for cloud
anderssonw Jul 22, 2024
c0f1b8e
use correct filename for cloud logback
anderssonw Jul 22, 2024
3ea984e
remove old comment
anderssonw Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ FROM eclipse-temurin:21-jdk-alpine
EXPOSE 8080:8080
RUN mkdir /app
COPY --from=build /home/gradle/src/build/libs/*.jar /app/matrikkel-bygning-egenregistrering.jar
ENTRYPOINT ["java","-jar","/app/matrikkel-bygning-egenregistrering.jar"]
ENTRYPOINT ["java", "-Dlogback.configurationFile=logback-cloud.xml", "-jar","/app/matrikkel-bygning-egenregistrering.jar"]
11 changes: 3 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ skal kunne ta i mot egenregistrert data om bygninger og bruksenheter fra Team Eg

## Lokalt oppsett

### Kjøring av applikasjon

Prosjektet er satt opp med IntelliJ på MacOS. Dersom noe ikke fungerer, med andre IDEer eller operativsystemer, gjerne
fyll ut README med informasjon om dette.

Expand All @@ -27,11 +29,4 @@ $ docker-compose up web -d
```

Ellers er det bare å kjøre opp applikasjonen som ønsket via IntelliJ eller kommandolinje. Ingen spesielle hensyn som er
nødvendig rundt miljøkonfigurasjon, det skal ha sane defaults.

## TODOs

* Utvide det faktiske APIet. Akkurat nå er det veldig, veldig enkelt, og er bare til for å lage en slags struktur med
Java-standard db -> repo -> service -> route
* Sette opp menneske-vennlige logger for lokal utvikling, da disse er ganske kjipe å lese i JSON format
* Error Boundaries på ruting og databasekall
nødvendig rundt miljøkonfigurasjon, det skal ha sane defaults.
12 changes: 12 additions & 0 deletions src/main/resources/logback-cloud.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<configuration>
<appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
<encoder class="net.logstash.logback.encoder.LogstashEncoder">
<provider class="net.logstash.logback.composite.loggingevent.ArgumentsJsonProvider"/>
</encoder>
</appender>
<root level="INFO">
<appender-ref ref="STDOUT"/>
</root>
<logger name="org.eclipse.jetty" level="INFO"/>
<logger name="io.netty" level="INFO"/>
</configuration>
5 changes: 2 additions & 3 deletions src/main/resources/logback.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<configuration>
<!-- TODO: Sett opp human readable logs for lokal utvikling-->
<appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
<encoder class="net.logstash.logback.encoder.LogstashEncoder">
<provider class="net.logstash.logback.composite.loggingevent.ArgumentsJsonProvider"/>
<encoder>
<pattern>%d{YYYY-MM-dd HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern>
</encoder>
</appender>
<root level="INFO">
Expand Down