Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator/pkg/karmadaresource: unit test ValidatingWebhookConfiguration and MutatingWebhookConfiguration #5605

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

operator/pkg/karmadaresource: unit test ValidatingWebhookConfiguration and MutatingWebhookConfiguration #5605

wants to merge 1 commit into from
+130 −0

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we introduce unit tests for mutating and validating webhook configurations to make sure they are working as expected.

What type of PR is this?

Which issue(s) this PR fixes:

Part of #5491.

Does this PR introduce a user-facing change?:

NONE

@mohamedawnallah
operator/pkg: test webhook configurations
b020df1 
In this commit, we introduce unit tests for mutating and validating webhook
configurations to make sure they are working as expected.

Signed-off-by: Mohamed Awnallah <[email protected]>
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign calvin0327 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.09%. Comparing base (4c8bcd4) to head (b020df1).
Report is 48 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5605      +/-   ##
==========================================
+ Coverage   34.14%   35.09%   +0.95%     
==========================================
  Files         643      645       +2     
  Lines       44524    44861     +337     
==========================================
+ Hits        15203    15745     +542     
+ Misses      28165    27894     -271     
- Partials     1156     1222      +66
Flag Coverage Δ
unittests 35.09% <ø> (+0.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah mohamedawnallah mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvin0327 calvin0327 Awaiting requested review from calvin0327

@chaosi-zju chaosi-zju Awaiting requested review from chaosi-zju

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohamedawnallah @karmada-bot @codecov-commenter