Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for multiclusterservice controller #5589

Conversation

anujagrawal699
Copy link
Contributor

Description:
This PR introduces comprehensive unit tests for the Multi-Cluster Services controllers. These tests aim to improve code reliability and facilitate easier maintenance and future development.

Additions:

  1. pkg/controllers/multiclusterservice/endpointslice_collect_controller_test.go
  2. pkg/controllers/multiclusterservice/endpointslice_dispatch_controller_test.go
  3. pkg/controllers/multiclusterservice/mcs_controller_test.go

Test Coverage:

  1. endpointslice_collect_controller_test.go : 0% to 24.5%
  2. endpointslice_dispatch_controller_test.go : 0% to 44.6%
  3. mcs_controller_test.go : 0% to 38.2%

Overall coverage of multiclusterservice controller : 0% to 35.8%

What type of PR is this?
/kind failing-test
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 22, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 22, 2024
@anujagrawal699
Copy link
Contributor Author

Hi @mohamedawnallah, #5287 is failing. Can you please check.

@mohamedawnallah
Copy link
Contributor

Thanks, @anujagrawal699, for the heads-up! @XiShanYongYe-Chang proactively submitted a PR for this (#5580) and it's currently under review.

@anujagrawal699
Copy link
Contributor Author

Thanks, @anujagrawal699, for the heads-up! @XiShanYongYe-Chang proactively submitted a PR for this (#5580) and it's currently under review.

Ohkay, Thanks!

@XiShanYongYe-Chang
Copy link
Member

/retest

@XiShanYongYe-Chang
Copy link
Member

/assign

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.83%. Comparing base (673a603) to head (b7b508b).
Report is 26 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5589      +/-   ##
==========================================
+ Coverage   34.10%   34.83%   +0.72%     
==========================================
  Files         645      645              
  Lines       44857    44857              
==========================================
+ Hits        15298    15624     +326     
+ Misses      28400    28028     -372     
- Partials     1159     1205      +46     
Flag Coverage Δ
unittests 34.83% <ø> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
@karmada-bot karmada-bot merged commit 12cd43e into karmada-io:master Sep 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants