Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karmada-operator: Grand proxy permission to system:admin #5572

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Sep 20, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

auto authorize system:admin to proxy member clusters in operation install method

Which issue(s) this PR fixes:

Fixes #5571

Special notes for your reviewer:

test report:

$ karmadactl --karmada-context karmada-apiserver get deploy --operation-scope members
NAME    CLUSTER   READY   UP-TO-DATE   AVAILABLE   AGE   ADOPTION
nginx   member1   1/1     1            1           9s    Y

Does this PR introduce a user-facing change?:

`karmada-operator`: Fixed `system:admin` can not proxy to member cluster issue.

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 20, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 20, 2024
@chaosi-zju chaosi-zju changed the title auto authorize system:admin to proxy member clusters in operation install method karmada-operator: authorize system:admin to proxy member clusters during installation to fix karmadactl command failure Sep 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 34.85%. Comparing base (b8edec1) to head (25357ee).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
operator/pkg/karmadaresource/rbac/rbac.go 0.00% 20 Missing ⚠️
operator/pkg/util/apiclient/idempotency.go 0.00% 14 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5572      +/-   ##
==========================================
+ Coverage   33.93%   34.85%   +0.92%     
==========================================
  Files         645      645              
  Lines       44857    44861       +4     
==========================================
+ Hits        15220    15636     +416     
+ Misses      28479    28019     -460     
- Partials     1158     1206      +48     
Flag Coverage Δ
unittests 34.85% <0.00%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaosi-zju
Copy link
Member Author

/cc @XiShanYongYe-Chang @zhzhuang-zju can you help doing a review

@karmada-bot
Copy link
Collaborator

@chaosi-zju: GitHub didn't allow me to request PR reviews from the following users: doing, a, review, can, you.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @XiShanYongYe-Chang @zhzhuang-zju can you help doing a review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we need it.
LGTM

@zhzhuang-zju
Copy link
Contributor

thanks
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@chaosi-zju
Copy link
Member Author

cc @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

@RainbowMango
Copy link
Member

/retitle karmada-operator: Grand proxy permission to system:admin

@karmada-bot karmada-bot changed the title karmada-operator: authorize system:admin to proxy member clusters during installation to fix karmadactl command failure karmada-operator: Grand proxy permission to system:admin Sep 24, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, just some nits from me.

operator/pkg/karmadaresource/rbac/rbac.go Outdated Show resolved Hide resolved
operator/pkg/util/apiclient/idempotency.go Outdated Show resolved Hide resolved
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@chaosi-zju
Copy link
Member Author

/cc @RainbowMango ci is ready

@karmada-bot
Copy link
Collaborator

@chaosi-zju: GitHub didn't allow me to request PR reviews from the following users: ci, is, ready.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @RainbowMango ci is ready

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2024
@karmada-bot karmada-bot merged commit 5f7fc4f into karmada-io:master Sep 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to proxy to member clusters with Karmada deployed by karmada-operator
6 participants