pkg/webhook: unit test Interpreter #5542
Conversation
karmada-bot
added
the
size/XL
mohamedawnallah
force-pushed
the
unitTestInterpreter
branch
from
bbcf86e
to
f01637c
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5542 +/- ##
==========================================
+ Coverage 34.14% 35.14% +1.00%
==========================================
Files 643 645 +2
Lines 44509 44833 +324
==========================================
+ Hits 15197 15756 +559
+ Misses 28156 27870 -286
- Partials 1156 1207 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/assign |
|
Hi @mohamedawnallah, can you help squash the commits into one? |
In this commit, we introduce unit tests for the `Interpreter` webhook across `Decoder`, `HTTP`, `Injection`, `Response`, and `Webhook` components. Signed-off-by: Mohamed Awnallah <[email protected]>
mohamedawnallah
force-pushed
the
unitTestInterpreter
branch
from
f01637c
to
1c5049f
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Closing and reopening some flaky e2e test cases... |
|
Hi @XiShanYongYe-Chang, I've squashed the commits into single one and all tests passed :) |
There was a problem hiding this comment.
Hi @mohamedawnallah can you try to rewrite it as table drive?
|
|
||
| req := httptest.NewRequest(http.MethodPost, "/", nil) | ||
| rec := httptest.NewRecorder() | ||
| req.Body = nil |
There was a problem hiding this comment.
Is this line redundant?
Description
In this commit, we introduce unit tests for the
Interpreterwebhook acrossDecoder,HTTP,Injection,Response, andWebhookcomponents.What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Does this PR introduce a user-facing change?: