pkg/webhook: unit test Federated HPA #5507
Conversation
karmada-bot
added
the
size/L
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5507 +/- ##
==========================================
+ Coverage 31.70% 32.51% +0.81%
==========================================
Files 643 643
Lines 44445 45107 +662
==========================================
+ Hits 14090 14667 +577
- Misses 29325 29335 +10
- Partials 1030 1105 +75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
In this commit, we introduce unit tests for both the `MutatingAdmission`
and `ValidatingAdmission` webhooks specifically for the `FederatedHPA`
resource.
The tests include:
- Validation webhook tests:
- Verifies that admission is denied with an appropriate error message
when decoding the request object fails.
- Ensures admission is denied when the `FederatedHPA` spec contains
invalid values, such as a `minReplicas` set to zero, and the correct
error message is returned.
- Confirms that a valid `FederatedHPA` object is allowed through without
errors.
- Mutation webhook tests:
- Verifies that admission is denied when decoding the request object
fails, returning the appropriate error message.
- Ensures that the `FederatedHPA` object is correctly mutated when
provided with default values, including scale policies and CPU
utilization.
- Confirms that no patches are applied when the `FederatedHPA` object is
handled correctly and that admission is allowed for valid
`FederatedHPA` objects.
Signed-off-by: Mohamed Awnallah <[email protected]>
mohamedawnallah
force-pushed
the
unitTestFederatedHPAWebhook
branch
from
250f6f4
to
e5169f8
Compare
|
Closing and reopening some flaky e2e test failures... |
|
All tests passed now—awesome! :) |
|
/assign |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Description
In this commit, we introduce unit tests for both the
MutatingAdmissionandValidatingAdmissionwebhooks specifically for theFederatedHPAresource.The tests include:
Validation webhook tests:
FederatedHPAspec contains invalid values, such as aminReplicasset to zero, and the correct error message is returned.FederatedHPAobject is allowed through without errors.Mutation webhook tests:
FederatedHPAobject is correctly mutated when provided with default values, including scale policies and CPU utilization.FederatedHPAobject is handled correctly and that admission is allowed for validFederatedHPAobjects.What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Does this PR introduce a user-facing change?: