-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for controllers/deploymentreplicassyncer #5493
base: master
Are you sure you want to change the base?
Added tests for controllers/deploymentreplicassyncer #5493
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8c04229
to
1a16c6b
Compare
The TestSetupWithManager is removed in the latest commit because it was causing CI failures and provided limited value in terms of testing the controller's core functionality. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5493 +/- ##
==========================================
+ Coverage 31.70% 31.81% +0.11%
==========================================
Files 643 643
Lines 44445 44445
==========================================
+ Hits 14090 14142 +52
+ Misses 29325 29270 -55
- Partials 1030 1033 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Anuj Agrawal <[email protected]> Added tests for controllers/deploymentreplicassyncer Signed-off-by: Anuj Agrawal <[email protected]> Added tests for controllers/deploymentreplicassyncer Signed-off-by: Anuj Agrawal <[email protected]>
1a16c6b
to
9f02242
Compare
@XiShanYongYe-Chang Please take a look. |
Description:
This PR introduces tests for deploymentreplicassyncer controller. The new addition tests significant logic of deploymentreplicassyncer controller.
Additions:
TestPredicateFunc:
TestSetupWithManager:
TestReconcile:
TestIsDeploymentStatusCollected:
Test Coverage:
The test coverage of the deploymentreplicassyncer controller has been increased to 63.9% .
What type of PR is this?
/kind failing-test
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: