Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed responsiveness for social media bar #523

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

pawan43563
Copy link

@pawan43563 pawan43563 commented Sep 24, 2021

Earlier: post social media links were going next line which was giving bad user experience.
solution: while resizing checking if it is going to next line or not if it is going than giving another share options(made use of existing share option) and hiding the icons which is going to next line .

@kakawait kakawait added the enhancement New feature or request label Oct 2, 2021
@kakawait kakawait added this to the 0.6.0 milestone Oct 2, 2021
@kakawait
Copy link
Owner

kakawait commented Oct 6, 2021

Thank you for your work.
I'll firstly review #384 because is a HUGE PR then I'll take time for your PR.

Do care about conflict on static/css/style-c5yjx2losbmkttdif4mskx5f9pqjjquywurgngxfvceyyrtyatseix5hpd.min.css because when I'll merge #384 there is high chance that new conflict occurs. So we'll wait for that PR merged to regenerate bundle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants