Use kairos logger #637
Use kairos logger #637
Conversation
Signed-off-by: Itxaka <[email protected]>
internal/provider/bootstrap.go
Outdated
| logging.SetAllLoggers(lvl) | ||
|
|
||
| log := &logging.ZapEventLogger{SugaredLogger: *logger.Sugar()} | ||
| logger := types.NewKairosLogger("agent", logLevel, false) |
There was a problem hiding this comment.
this is the main change, dropping the zap logger for our kairos generic logger
There was a problem hiding this comment.
Does our logger log to a file too? It would be nice if that was configured centrally somewhere. Obviously it doesn't make sense to handle this everywhere we create a logger (env var maybe?). Not for this PR though.
There was a problem hiding this comment.
It does. It tries to create files both to /run/Kairos and /var/log/Kairos so it would write logs even if for some reason /var/log is immutable, we still got the /run/Kairos logs
Ideally a couple of methods to pass along your own log locations should be added so consumers can set their own locations but it didn't seem necessary at the time so I postponed adding it for now
Signed-off-by: Itxaka <[email protected]>
No need to test if we log to file Signed-off-by: Itxaka <[email protected]>
|
blocked until I can manually test it :D |
Signed-off-by: Itxaka <[email protected]>
|
tested adn works as expected! |
No point into having different loggers, this will use our generic kairos logger with the agent name and store things into the same places as everything else. Plus we do not put the burden of creating the log files into the even emitters which was weird.
Plus any changes to the logger will reflect everywhere and we have the same format