Fix online status with more than one NIC #1081
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For systems with more than one unconfigured NIC, this allows the system to see any one interface online as enough to proceed with online status. Fixes kairos-io/kairos#2898 Signed-off-by: Ben Corrado <[email protected]>
Itxaka
requested changes
Sep 28, 2024
There was a problem hiding this comment.
I would drop the --ipv4 in case we got a network with only ipv6 maybe? if that is not specified, it seems that it will use the configuration from the device to know which version to use so it may be better that way.
Also this will fail to pass CI because you need to bump the minor version of the package, so it gets properly build. Just bump the patch version on https://github.com/kairos-io/packages/blob/main/packages/static/kairos-overlay-files/collection.yaml#L4 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For systems with more than one unconfigured NIC, this allows the system to see any one interface online as enough to proceed with online status. Fixes kairos:#2898