refactor: compact pending-acks #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
zmstone
force-pushed
the
0909-support-static-ack-callbacks
branch
from
b3f5fe1
to
24a8f30
Compare
zmstone
force-pushed
the
0909-support-static-ack-callbacks
branch
3 times, most recently
from
c49ad22
to
f6e2f56
Compare
thalesmg
approved these changes
Sep 10, 2024
Comment on lines
+92
to
+91
| -spec take(acks(), call_id()) -> {ok, cb(), acks()} | false. | ||
| take(#{cbs := Cbs} = X, Id) -> |
There was a problem hiding this comment.
Q: since this might receive a disk queue item containing ?no_caller_ack as the call id, maybe it should immediately return false if such value is the input?
There was a problem hiding this comment.
no_caller_ack was a left-over (forgot to delete) when I refactored the batch split algorithm.
My previous iteration of the batch-split algorithm tried to split the batch of a call.
Given one call only needed one ack, I added no_caller_ack for the rest of the split-items.
This caused a lot complexity, later I refactored it to drop the entire call if the batch is too large, but I forgot to remove no_caller_ack.
zmstone
force-pushed
the
0909-support-static-ack-callbacks
branch
from
f6e2f56
to
c401ed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the producer uses a map to hold pending acks under the assumption that the map values should be small.
in some complex scenarios, however, the ack callback contexts can be large terms this result in great RAM consumption when there are many to ack.
This PR optimizes RAM usage by: