Delete global stats module #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
0906-delete-stats
branch
from
6566ee7
to
9e4f844
Compare
thalesmg
approved these changes
Sep 6, 2024
| @@ -285,8 +278,7 @@ handle_info({do_init, St0}, _) -> | |||
| handle_info(?linger_expire, St) -> | |||
| {noreply, maybe_send_to_kafka(St#{?linger_expire_timer := false})}; | |||
| handle_info(?SEND_REQ(_, Batch, _) = Call, #{config := #{max_batch_bytes := Limit}} = St0) -> | |||
| {Calls, Cnt, Oct} = collect_send_calls([Call], 1, batch_bytes(Batch), Limit), | |||
| ok = recv_stats(St0, #{cnt => Cnt, oct => Oct}), | |||
| {Calls, _CollectedBytes} = collect_send_calls([Call], batch_bytes(Batch), Limit), | |||
There was a problem hiding this comment.
Seems like CollectedBytes is no longer used anywhere else, so we don't need to keep track of it in collect_send_calls?
There was a problem hiding this comment.
right, this part will be re-written in the next pr.
zmstone
force-pushed
the
0906-delete-stats
branch
from
9e4f844
to
9f01b48
Compare
thalesmg
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.