perf: use ets table for client ID registration #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
reviewed
Dec 15, 2023
| %% @doc Insert the client in the registration table. | ||
| register_client(ClientId) -> | ||
| Pid = self(), | ||
| true = ets:insert(?WOLFF_CLIENTS_GLOBAL_TABLE, {ClientId, Pid}), |
There was a problem hiding this comment.
Nit: maybe use ets:insert_new to avoid overwriting a previous entry?
There was a problem hiding this comment.
it should always overwrite.
client process may restart (by supervisor) after crash
zmstone
force-pushed
the
1215-perf-client-lookup
branch
2 times, most recently
from
0ceffb1
to
a1437b0
Compare
zmstone
force-pushed
the
1215-perf-client-lookup
branch
from
a1437b0
to
677e298
Compare
qzhuyan
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a performance optimization incorporated with a refactoring.
Performance fix
supervisor:which_children(wolff_client_sup)becomes quite expensive when there are many clients started (thousands).Main caller is
wolff:check_conectivity/1.The fix is to store client ID -> Pid in a ets table.
Refactoring
1.9.0 made use of the producer name as ETS table key for producer process registration.
However that lead to two minor problems:
{ClientId, Topic}uses the same producer name.the fix is to use
{ClientId, Topic}as the ID, and the old "name" is only used as process registry (when it's an atom) for backward compatibility.