1029 check topic with clinet pid #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this new API, to check topic existence, the caller would need to keep the seed-hosts and connection configs around so they can call the check_if_topic_exists/3 API even when a client is already present. The new API delegates the call to wolff_client process to do the check, otherwise nothing changed.
zmstone
force-pushed
the
1029-check-topic-with-clinet-pid
branch
from
77dac7d
to
aab147c
Compare
id
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this new API, to check topic existence, the caller would
need to keep the seed-hosts and connection configs around so they
can call the check_if_topic_exists/3 API even when a client is
already present.
The new API delegates the call to wolff_client process to do
the check, otherwise nothing changed.