Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wolff_producers should not crash when client is killed #49

Merged
merged 4 commits into from
Aug 3, 2023
Merged

fix: wolff_producers should not crash when client is killed #49

merged 4 commits into from
Aug 3, 2023

Conversation

zmstone
Copy link
Contributor

@zmstone zmstone commented Aug 3, 2023 •
edited
Loading

fixes: #48

@zmstone zmstone requested review from id, qzhuyan and thalesmg August 3, 2023 09:09
thalesmg
thalesmg approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@thalesmg thalesmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a changelog entry?

@zmstone zmstone merged commit bc1fbf0 into kafka4beam:main-1.5 Aug 3, 2023
6 checks passed
@zmstone zmstone deleted the 0803-producers-should-not-crash-when-client-is-killed branch August 3, 2023 12:51
@zmstone zmstone mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terry-xiaoyu terry-xiaoyu terry-xiaoyu approved these changes

@thalesmg thalesmg thalesmg approved these changes

@id id Awaiting requested review from id

@qzhuyan qzhuyan Awaiting requested review from qzhuyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmstone @terry-xiaoyu @thalesmg