Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: socket write error should not result in a crash report #124

Merged
merged 2 commits into from
Aug 27, 2024
Merged

fix: socket write error should not result in a crash report #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f418e1b
fix: socket write error should not result in a crash report
zmstone Aug 27, 2024
a2cb69f
docs: add changelog
zmstone Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
* 4.1.8
- Avoid generating crash-report when failed to write socket [PR#124](https://github.com/kafka4beam/kafka_protocol/pull/124)

* 4.1.7
- Automatically re-authenticate before session lifetime expires if SASL
authentication module returns `{ok, ServerResponse}` and ServerResponse
Expand Down
2 changes: 1 addition & 1 deletion src/kpro_connection.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ send_request({From, {send, Request}},
, {caller, Caller}
, {reason, Reason0}
],
exit({send_error, Reason})
exit({shutdown, Reason})
end,
State#state{requests = NewRequests}.

Expand Down
Loading