Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Rename "max size on disk" to "Max partition size" #388

Merged
merged 2 commits into from
May 16, 2024

Conversation

svrmnk
Copy link
Contributor

@svrmnk svrmnk commented May 15, 2024

What changes did you make? (Give an overview)

Fixes #86

I renamed input label "max size on disk" to "Max partition size"

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@svrmnk svrmnk requested a review from a team as a code owner May 15, 2024 09:38
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 15, 2024
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svrmnk could you please also fix the tests? Thank you

@svrmnk svrmnk requested a review from Haarolean May 15, 2024 12:34
@Haarolean Haarolean changed the title issue 86: Rename "max size on disk" to "Max partition size" FE: Rename "max size on disk" to "Max partition size" May 16, 2024
@Haarolean Haarolean added scope/frontend Related to frontend changes type/chore Boring stuff, could be refactoring or tech debt and removed status/triage/manual Manual triage in progress labels May 16, 2024
@Haarolean Haarolean merged commit ec1b354 into kafbat:main May 16, 2024
23 of 24 checks passed
@Haarolean
Copy link
Member

@svrmnk thanks for your first contribution to kafbat ui!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: Rename "max size on disk" to "Max partition size"
2 participants