Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing whitespace #9362

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ruzko
Copy link

@ruzko ruzko commented Feb 6, 2024

Proposed Changes

There were a few spots in the install.sh script with trailing whitespaces.
This PR removes those.

Types of Changes

bugfix, formatting

Verification

Open master branch and this PR in nano with highlighting of trailing spaces

Testing

Should be unnecessary

Linked Issues

This is so small, I didn't want to create an issue for it.

User-Facing Change

NONE

Further Comments

@ruzko ruzko requested a review from a team as a code owner February 6, 2024 21:06
Copy link
Contributor

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We do still need an issue though, for our QA processes ;)

@ruzko
Copy link
Author

ruzko commented Feb 6, 2024

Thanks :)
Made a related issue: #9363

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57482a1) 45.69% compared to head (d905bb5) 26.62%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9362       +/-   ##
===========================================
- Coverage   45.69%   26.62%   -19.07%     
===========================================
  Files         154      154               
  Lines       16623    16623               
===========================================
- Hits         7596     4426     -3170     
- Misses       7814    11429     +3615     
+ Partials     1213      768      -445     
Flag Coverage Δ
e2etests ?
inttests 21.21% <ø> (-16.37%) ⬇️
unittests 15.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants