Add support raspbian bullseye #185
Conversation
husjon
force-pushed
the
add_support-raspbian_bullseye
branch
2 times, most recently
from
77bdcb1
to
9d57bfe
Compare
roles/raspberrypi/tasks/main.yml
Outdated
| - ansible_facts.lsb.description|default("") is match("Debian.*buster") | ||
|
|
||
| - name: Set detected_distribution to Raspbian (ARM64 on Debian Bullseye) | ||
| set_fact: | ||
| detected_distribution: Raspbian | ||
| when: | ||
| - ansible_facts.architecture is search("aarch64") | ||
| - raspberry_pi|default(false) | ||
| - ansible_facts.lsb.description|default("") is match("Debian.*bullseye") |
There was a problem hiding this comment.
I made the detection task a separate task for bullseye to be explicit for bullseye, but if prefered, this can be combined with the buster match.
A few comments on this would be appreciated.
Example change:
| - ansible_facts.lsb.description|default("") is match("Debian.*buster") | |
| - name: Set detected_distribution to Raspbian (ARM64 on Debian Bullseye) | |
| set_fact: | |
| detected_distribution: Raspbian | |
| when: | |
| - ansible_facts.architecture is search("aarch64") | |
| - raspberry_pi|default(false) | |
| - ansible_facts.lsb.description|default("") is match("Debian.*bullseye") | |
| - ansible_facts.lsb.description|default("") is match("Debian.*(buster|bullseye)") |
|
Here's a screenshot of the load from the server while adding agents.
|
|
Nice work! I would have solved it in nearly the same way. However, adding the codename (which is a one to one map of major version) is redundant imo, and I would suggest we use only one of major version and codename. |
|
Thanks for the feedback, I don't mind either solution, I just found it easier to read the codenames rather than version numbers for the task filenames. :) I'll prepare a commit with the necessary changes. |
husjon
force-pushed
the
add_support-raspbian_bullseye
branch
from
506adef
to
85641a8
Compare
|
@ozgurgul and @JohanNicander, is there a reason this fix is approved but hasn't been merged? |
I had to implement this fix the other day setting up a new Raspberry Pi cluster with Raspberry Pi OS, so I'm wondering the same thing. This seems like a simple fix that should be merged with little issue. |
I'm not a contributor to this repo. Hence I can't merge this PR but otherwise I share the same thoughts. |
|
Hi @St0rmingBr4in what is required for this PR to be merged? |
|
Please can this PR get merged sooner rather than later. Thanks. |
|
This is really helpful! |
|
tested this on my raspberry pi cm4 cluster and totally works 👍 |
|
I'm SO tempted to use this. I tried to spin up my cluster with an I say this PR should be merged! |
Signed-off-by: Jon Erling Hustadnes <[email protected]>
Signed-off-by: Jon Erling Hustadnes <[email protected]>
Signed-off-by: Jon Erling Hustadnes <[email protected]>
Signed-off-by: Jon Erling Hustadnes <[email protected]>
Renamed task file to `Raspbian-11` (from `Raspbian-bullseye`) Removed set_facts for distribution codename Signed-off-by: Jon Erling Hustadnes <[email protected]>
dereknola
force-pushed
the
add_support-raspbian_bullseye
branch
from
85641a8
to
7ff5fe1
Compare
|
Closing in favor of changes in #151 |
This PR adds support for raspbian bullseye.
It has been tested on newly flashed pi3b+ nodes (combination of buster and bullseye) with only SSH enabled.
(I do currently not have pi4 nodes in my possession)
Test run output: https://gist.github.com/husjon/00965e50afffd8865e8ac3db66edb30f
What's been changed:
iptableson Rasbpian Bullseye (this is because bullseye comes withnftablespreinstalled)On bullseye using
Pi3B+this seem to bring the server to its knees, seeing average loads up to 15 while agents are added.This makes it so that the agents are unable to communicate with the server. (screenshot in comments)