Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD: Add aliased TARGETARCH builds #561

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Yurzs
Copy link

@Yurzs Yurzs commented Jan 9, 2024

Issue:

  • when using docker to build images depending on s6-overlay Dockers $TARGETARCH env variable for aarch64 is set to arm64, so each multi-arch dependent project have to implement if statement replacing arm64 -> aarch64 in their Dockerfile.

Solution:

  • create an alias for aarch64 -> arm64 archive in CI

@Yurzs Yurzs changed the title ci/cd: Add alias for aarch64 ci/cd: Add arm64 alias for aarch64 Jan 9, 2024
@skarnet
Copy link
Contributor

skarnet commented Jan 9, 2024

The main problem with supporting the TARGETARCH naming pattern is that it duplicates the artifacts. Please read this thread.

I understand this is inconvenient, but I'm not convinced providing twice the amount of files under different names is the answer.

@Yurzs
Copy link
Author

Yurzs commented Jan 9, 2024

I understand this is inconvenient, but I'm not convinced providing twice the amount of files under different names is the answer.

But still the workaround can be implemented so fellow devs don't suffer.
If GitHub implements support for symlinks in the releases then it can be used instead.
500KB file on each release won't do much.

@skarnet
Copy link
Contributor

skarnet commented Jan 9, 2024

I'm not adding an exception for aarch64. If you want the problem to be solved, please suggest a solution that works for all architectures. This is not an easy task; we've thought about it, and haven't found anything satisfactory.

It's not only a question of storage, it's also a question of clarity for users. If two tarballs with different names are effectively the same, this can cause confusion.

Having GitHub support for explicit symlinks (displayed as such in the downloads page) would solve both problems at once. Unfortunately, it's not under our control.

@Yurzs Yurzs marked this pull request as draft January 10, 2024 07:55
@Yurzs Yurzs changed the title ci/cd: Add arm64 alias for aarch64 CI/CD: Add aliased TARGETARCH builds Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants