feat: added snapshot_list and single view UI #249
Conversation
sauraww
commented
Sep 26, 2024
sauraww
commented
- Added Snapshot UI List Page
- Added Single Snapshot Page
|
|
||
| <Route | ||
| ssr=SsrMode::Async | ||
| path="/admin/:tenant/snapshots" |
There was a problem hiding this comment.
Should we keep snapshots in the url or config-versions as we are using config-versions for the endpoint and the table as as well?
There was a problem hiding this comment.
I think in UI it would become confusing if endpoints are config-versions and page shows snapshot.
| /> | ||
| <Route | ||
| ssr=SsrMode::Async | ||
| path="/admin/:tenant/snapshots/:version" |
|
|
||
| view! { | ||
| <Suspense fallback=move || view! { <p>"Loading..."</p> }.into_view()> | ||
| {move || { |
There was a problem hiding this comment.
Can we have some kind of heading here, taking inspiration from the experiment page maybe?
There was a problem hiding this comment.
Yeah , I will add it.
| @@ -314,3 +314,19 @@ pub struct FetchTypeTemplateResponse { | |||
| pub total_pages: i64, | |||
| pub data: Vec<TypeTemplate>, | |||
| } | |||
|
|
|||
| #[derive(Debug, Clone, Deserialize, Serialize)] | |||
| pub struct SnapshotResponse { | |||
There was a problem hiding this comment.
You may have to change it similar to what i have done for the endpoint response type.
sauraww
force-pushed
the
feat/snapshot-list-ui
branch
3 times, most recently
from
d783646
to
3e1cb92
Compare
sauraww
force-pushed
the
feat/snapshot-list-ui
branch
from
3e1cb92
to
7bf8df3
Compare
| @@ -51,6 +52,24 @@ pub async fn fetch_default_config( | |||
| Ok(response) | |||
| } | |||
|
|
|||
| pub async fn get_snapshots(tenant: String) -> Result<SnapshotResponse, ServerFnError> { | |||
There was a problem hiding this comment.
| pub async fn get_snapshots(tenant: String) -> Result<SnapshotResponse, ServerFnError> { | |
| pub async fn fetch_snapshots(tenant: String) -> Result<SnapshotResponse, ServerFnError> { |
There was a problem hiding this comment.
Better to follow the same naming pattern across all functions
| @@ -248,3 +267,24 @@ pub async fn fetch_types( | |||
| .await | |||
| .map_err(err_handler) | |||
| } | |||
|
|
|||
| pub async fn get_config_by_version( | |||
There was a problem hiding this comment.
An already existing function fetch_config can be re-purposed to fetch config by version.
There was a problem hiding this comment.
This file can be named snapshot.rs
| use leptos_router::use_params_map; | ||
|
|
||
| #[component] | ||
| pub fn SnapshotConfig() -> impl IntoView { |
There was a problem hiding this comment.
| pub fn SnapshotConfig() -> impl IntoView { | |
| pub fn snapshot() -> impl IntoView { |
There was a problem hiding this comment.
Please run leptosfmt, indetation is off in view macro
| ); | ||
|
|
||
| view! { | ||
| <Suspense fallback=move || view! { <p>"Loading..."</p> }.into_view()> |
There was a problem hiding this comment.
Use the loading skeleton for fallback in Suspense
| use crate::api::get_snapshots; | ||
|
|
||
| #[derive(Serialize, Deserialize, Clone, Debug)] | ||
| struct CombinedResource { |
There was a problem hiding this comment.
No need of CombinedResource here, we just have one resource to load i.e. snapshots.
| }); | ||
|
|
||
| let table_columns = | ||
| create_memo(move |_| snapshot_table_columns(tenant_rs.get_untracked())); |
There was a problem hiding this comment.
| create_memo(move |_| snapshot_table_columns(tenant_rs.get_untracked())); | |
| create_memo(move |_| snapshot_table_columns(tenant_rs.get())); |
this has to be reactive to any changes made to tenant.
| let combined_resource: Resource<String, CombinedResource> = create_blocking_resource( | ||
| move || tenant_rs.get(), | ||
| |current_tenant| async move { | ||
| match get_snapshots(current_tenant.to_string()).await { |
There was a problem hiding this comment.
We have a paginated API and still fetching all the snapshots at once. You can refer to experiment_list.rs to check how it can be done.
| let href = format!("/admin/{}/snapshots/{}", tenant, id); | ||
| view! { | ||
| <div> | ||
| <A href=href class="btn-link"> |
There was a problem hiding this comment.
The hyperlink can be added directly to the id value, that should be enough.
mahatoankitkumar
force-pushed
the
feat/get-snapshots
branch
from
6594ee1
to
25eb4c6
Compare
