fix: empty-override-prompt-text #216
Conversation
| .collect_view() | ||
| if ctx_n_overrides.is_empty() { | ||
| view! { | ||
| <div class="flex font-semibold items-center justify-center"> |
There was a problem hiding this comment.
@pratikmishra356 Can we check if this is required in any other screen?
There was a problem hiding this comment.
Also can this be vertically centered?
There was a problem hiding this comment.
I checked this is not required in other screen,
I think it should not be vertically centre as one had to look down a bit,
since overrides text and create button is on top it is better to be aligned towards top
There was a problem hiding this comment.
You can make the text bigger, and then center it. May need an icon as well
There was a problem hiding this comment.
sure checking
| if ctx_n_overrides.is_empty() { | ||
| view! { | ||
| <div class="flex font-semibold items-center justify-center"> | ||
| "Overrides has not been created yet" |
There was a problem hiding this comment.
| "Overrides has not been created yet" | |
| "Overrides have not been created yet" |
|
Can you change the commit message? And we should the change message to |
pratikmishra356
force-pushed
the
prompt-text-for-empty-override-page
branch
2 times, most recently
from
2f83136
to
5dfe38f
Compare
pratikmishra356
force-pushed
the
prompt-text-for-empty-override-page
branch
from
5dfe38f
to
72ff9f2
Compare
|
pratikmishra356
force-pushed
the
prompt-text-for-empty-override-page
branch
2 times, most recently
from
8f88351
to
94967b6
Compare
pratikmishra356
force-pushed
the
prompt-text-for-empty-override-page
branch
from
94967b6
to
4bfaf59
Compare
Datron
force-pushed
the
main
branch
9 times, most recently
from
6ca353c
to
41073fc
Compare
pratikmishra356
force-pushed
the
prompt-text-for-empty-override-page
branch
from
4bfaf59
to
a3a5080
Compare
| } | ||
| }) | ||
| .collect_view() | ||
| if ctx_n_overrides.is_empty() { |
There was a problem hiding this comment.
You can use <Show> component to achieve this.
And the else branch in not needed I guess, move the code out of the else branch.
There was a problem hiding this comment.
@ShubhranshuSanjeev can we take this later? I think this is fine for now.
|
Should we also get this out in other pages like default_config, dimensions, functions. Instead of showing empty tables? |
|
@mahatoankitkumar other pages have different structure (tabular) so it is not needed there i guess |
pratikmishra356
dismissed
ShubhranshuSanjeev’s stale review
Discussed offline
Problem
In case of empty overrides list , page does not have any prompt text to hint user
Solution
Added prompt text in case of empty page
Environment variable changes
What ENVs need to be added or changed
Pre-deployment activity
Things needed to be done before deploying this change (if any)
Post-deployment activity
Things needed to be done after deploying this change (if any)
API changes
Possible Issues in the future
Describe any possible issues that could occur because of this change