fix: haskell-client-doc #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we also, update the getConfig function in haskell, it is supposed to take Maybe [String] and concat them with "," and send it to cac client, but currently it is taking Maybe String (already assuming that the filters are joined with "," before passing it to the function) |
pratikmishra356
approved these changes
Aug 1, 2024
Datron
reviewed
Aug 1, 2024
| @@ -295,7 +295,7 @@ Get the full config definition of your tenants configuration from superposition. | |||
| ##### Funtion Definition | |||
|
|
|||
| ``` | |||
| getFullConfigStateWithFilter :: ForeignPtr CacClient -> Maybe String -> IO (Either Error Value) | |||
| getFullConfigStateWithFilter :: ForeignPtr CacClient -> Maybe String -> Maybe String -> IO (Either Error Value) | |||
There was a problem hiding this comment.
@mahatoankitkumar can we add the table explaining what each parameter is? I missed this the last time
mahatoankitkumar
force-pushed
the
fix/haskell-client-doc
branch
from
723a01c
to
e7df5c1
Compare
Datron
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
haskell client doc
Solution
fixed haskell client doc