feat: adding php cac and experimentation client wrapper #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namitgoel
force-pushed
the
php-cac-client
branch
from
94198e0
to
a0471df
Compare
Datron
requested changes
Aug 26, 2024
| char* cac_get_config(char* tenantPtr, char* filter_query, char* filter_prefix); | ||
| char* cac_get_resolved_config(char* tenantPtr, char* query, char* filter_keys, char* merge_strategy); | ||
| char* cac_get_default_config(char* tenantPtr, char* filter_keys); | ||
| ", "/Users/namit.goel/Desktop/repos/namit_superposition/superposition/target/debug/libcac_client.dylib"); |
There was a problem hiding this comment.
This should be dynamic right? @namitgoel
| @@ -0,0 +1,32 @@ | |||
| Set directory path that contains superposition object files in <span style="color: red" > SUPERPOSITION_LIB_PATH </span> env variable; | |||
There was a problem hiding this comment.
Can we mention what version of PHP this supports?
| char* expt_get_satisfied_experiments(char* exp_ptr, char* c_context, char* filter_prefix); | ||
| char* expt_get_filtered_satisfied_experiments(char* exp_ptr, char* c_context, char* filter_prefix); | ||
| char* expt_get_running_experiments(char* exp_ptr); | ||
| ", "/Users/namit.goel/Desktop/repos/namit_superposition/superposition/target/debug/libexperimentation_client.dylib"); |
|
@namitgoel add php in flakes.nix |
Datron
force-pushed
the
main
branch
11 times, most recently
from
02832c3
to
a9afdb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Describe the problem you are trying to solve here
Solution
Provide a brief summary of your solution so that reviewers can understand your code
Environment variable changes
What ENVs need to be added or changed
Pre-deployment activity
Things needed to be done before deploying this change (if any)
Post-deployment activity
Things needed to be done after deploying this change (if any)
API changes
Possible Issues in the future
Describe any possible issues that could occur because of this change