Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add section how to transfer your files simple to your server #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tzabbi
Copy link

@tzabbi tzabbi commented Oct 1, 2023

Add a guide which explains how to create a directory which will be used by the server. With this you can simply add custom files to your server.

@jusito
Copy link
Owner

jusito commented Oct 2, 2023

Heyho, I don't know if advising people to use bind mount is a good idea.

  1. The current image can't handle permission issues well. (Sure, fixable)
  2. Docker bind mount should be turned off for security reasons (any user mount "/" even malicious script). So there are configurations where bind mount will not work., therefore this readme wouldn't work.
  3. On some systems like WSL bind mount can come with a heavy performance penalty, e.g. if you bind mount a Windows to Linux shared folder.

But because it's for some reason quite often used and impacts the user I agree that there should be a note. Maybe in entrypoint checking if the permissions are fine and if not throwing a good error message with "What the issue? Whats the cause? How to solve?" e.g. "File permissions in /home/steam preventing correct Container execution. Some files in /home/steam aren't owned by the correct user steam with uid 10000. Please fix with docker run -it --rm -v VolumeName:/home alpine chown -R 10000 /home .

@jusito
Copy link
Owner

jusito commented Oct 2, 2023

In essence there is my question: why do you prefer bind mount instead of volumes?

@tzabbi
Copy link
Author

tzabbi commented Oct 3, 2023

You are totally right. For me it worked but I only uses Linux Server and Clients.

  1. What do you mean?
  2. I don't know that the bind mount is an security issue in combination with docker. So we should avoid it.
  3. I don't use WSL so I can't say something about this point.

I'll add this section and remove my points.

I just want add this bind mount, because it is easy to copy files to the container.

- bind mount and docker has security issues with docker and performance issues with WSL
- not every file has owner and group id 10000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants