Register all kernels in one plugin #107
Conversation
| broadcastChannel?: IBroadcastChannelWrapper | ||
| ) => { | ||
| const kernelPlugin: JupyterLiteServerPlugin<void> = { | ||
| id: '@jupyterlite/xeus-kernel:register', |
There was a problem hiding this comment.
Looks like having a single plugin would prevent disabling some kernels via disabledExtensions?
There was a problem hiding this comment.
We can keep the current behavior by checking for the PageConfig.disabledExtensions value in the activation function?
There was a problem hiding this comment.
The reason we need synchronous XHR is to generate JupyterLab plugins dynamically from the fetch data. Which I do not feel is necessary since these plugins do not provide any token. If it's just about to disable some kernels later, we can have other mechanisms
There was a problem hiding this comment.
Right, it would be great to remove this synchronous XHR.
There was a problem hiding this comment.
Do we really need the ability to disable kernels?
If users don't want a kernel in the UI, their solution is to not install it in the provided environment.yml file.
Closes #106