Text eliding with ellipsis on datagrid text renderer

[nmichaud]

This PR (phosphorjs/phosphor#341) was sitting latent on the phosphor repo - I ported it over to lumino. I removed the optionality of eliding text - I feel like in almost all cases it looks better visually, although if you feel otherwise i can add the option back. I also improved the margins around the text a bit for easier readability.

[blink1073]

cc @ellisonbg thoughts on this one?

[nmichaud]

This is what it looks like for the datagrid example:

[ellisonbg]

Can we make it configurable whether the ellipsis is at the beginning or end of the cell? The type of content will determine which is more optimal.

…

On Thu, Aug 20, 2020 at 11:01 AM Naveen Michaud-Agrawal < ***@***.***> wrote: This is what it looks like for the datagrid example: [image: image] <https://user-images.githubusercontent.com/648190/90808210-a618ef80-e2ed-11ea-8c82-beb60735b59c.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#105 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAGXUBNZU7OZ2OR6I5FYK3SBVQI5ANCNFSM4P63MZTQ> .

-- Brian E. Granger Principal Technical Program Manager, AWS AI Platform ([email protected]) On Leave - Professor of Physics and Data Science, Cal Poly @ellisonbg on GitHub

[nmichaud]

Can we make it configurable whether the ellipsis is at the beginning or end of the cell? The type of content will determine which is more optimal.

Yeah, that could be done as a ConfigOption on the renderer. Curious though - what type of content have you seen where ellipsis at the beginning was better?

Edit: unless you are thinking of right-to-left languages.

[nmichaud]

Here's how it looks:

[blink1073]

Released as part of @lumino/datagrid: 0.13.0 => 0.14.0

[vidartf]

Curious though - what type of content have you seen where ellipsis at the beginning was better?

File paths could be one :)